c# - refactoring if else -


i refactoring legacy code. there big if else statement. pattern can use. have used dictionary in past if-else has lot of (&&) don't know how refactor this.

for eg code is

    public void changecontrolvisibiltiy()       {         if (name != "i")         {            //do         }            if ((name != "a") && (name != "b") && (name != "c") && (name != "d") && (name != "f") && (name != "g") && (name != "h") && (name != "i") && (name != "j") && (name != "h") && (name != "i") && (name != "j"))         {            //do         }          if ((name != "a") && (name != "b") && (name != "d") && (name != "f") && (name != "g") && (name != "h") && (name != "i") && (name != "j") && (name != "h") && (name != "i") && (name != "j"))         {             //do          }          if ((name != "a"))         {             //do         }           if ((name != "a") && (name != "k") && (name != "l") )         {             //do         }           if ((name != "a") && (name != "k") && (name != "l") && (name != "b") && (name != "d") && (name != "f") && (name != "g") && (name != "h") && (name != "i") && (name != "j") && (name != "h") && (name != "i"))         {                 //do         }           if ((name != "a") && (name != "l"))         {             //do         }          if (name == "m")         {            //do         }          else if (name == "c")         {             //do         }         else         {           //do         }          }

well looks bit awkward remove 2. , 3. if statement. if have single parameter check can use switch statements.

nevertheless should use .equals() instead of == , please give real working code example. in general if have same code on , on again pattern extract new method e.g. if have smth name.equals("a") || name.equals("b") make new method oredequals(string name, string... matches).


Comments

Post a Comment

Popular posts from this blog

powershell Start-Process exit code -1073741502 when used with Credential from a windows service environment -

i'm running strange behavior powershell start-process call. here call: $process = start-process ` "c:\somepath\mybinary.exe" ` -passthru ` -credential $defaultcredential ` -wait ` -workingdirectory "c:\somepath" ` -loaduserprofile if ($process.exitcode -ne 0) { #do } this call return exit code - 1073741502 . after quick search, exit code seems related generic error when program not load required dll (aka. status_dll_init_failed ). when run without -credential $credential program runs correctly. in order isolate problem, manually launched some.exe in prompt target credential , runs smoothly. so problem seems come way start-process cmdlet launch process. i found potential solutions problem tried apply no luck : link , link . would have idea of what's going on here ? edit 1: run proc mon monitoring program activities when launched directly or via powershell script. problem seems occur when loading kernelbase
Read more

twig - Using Twigbridge in a Laravel 5.1 Package -

i'm trying create laravel 5.1 package uses twigbridge instead of .php views. can normal .php views display fine, when try make use of .twig templates i'm met error. possible use twigbridge templates when creating views laravel package or pretty stuck blade , php ? edit 1: loading twig template without extending works. it's when start using {% extends 'file' %} error comes out. i error error loading /virtual/laravel/packages/username/mypackage/src/views/sample.twig: template "templates.master" not defined () in "/virtual/laravel/packages/username/mypackage/src/views/sample.twig" @ line 1. my folders username |_ mypackage |_ src |_ controllers - samplecontroller.php |_ views |_ templates - master.twig - sample.twig twig template sample.twig {% extends 'templates.master' %} {% block content %} {{ parent()
Read more

c# - LINQ join Entities from HashSet's, Join vs Dictionary vs HashSet performance -

i have hashset's each stores t, have written test application compares different relation algorithms can think of, i'm not pleased results getting. does there exist more efficient ways of achieving object relations, once testing? using system; using system.collections.generic; using system.linq; using system.text; using system.threading.tasks; using system.diagnostics; namespace linqtests { class program { static void main(string[] args) { hashset<user> usertable = new hashset<user>(); hashset<userproperty> userpropertytable = new hashset<userproperty>(); #region lets create dummy data. console.writeline("please wait while creating dummy data, can take while..."); console.writeline(""); int rows = 1000000; for(int x = 0; x < rows; x++) { random rnd = new random(); // ad
Read more