javascript - optimizing div + screen resize JS block -


i'm struggling figure out best way optimize code. i'm using width @media tags, , js seems reliable way can control series of specific variables adjust div element.

it's mess realize, wanted feedback see if there glaring issues. still learning, go easy on me.

thanks.

jquery(document).ready(function($){     var elementheight = $('.hs-caption').height();     var screenheight = jquery(window).height();     var upcomingheader = $('.fold-header').height() * 2.0;     if (screenheight > 960) {     var heightoffset = 220;              } else {     var heightoffset = 200;      }      var totalheight = elementheight + heightoffset;  function fullscreen(){     jquery('#hero').css({         width: jquery(window).width(),         height: jquery(window).height()     }); }   function settocenterofparent(element, parent, ignorewidth, ignoreheight){     parentwidth = $(parent).width();     parentheight = $(parent).height();       elementwidth = $(element).width();     elementheight = $(element).height();     if(!ignorewidth)         $(element).css('left', parentwidth/2 - elementwidth/2);     if(!ignoreheight)         $(element).css('top', heightoffset); }     function scalar(){   if (window.innerheight < (totalheight * 1.25) + upcomingheader) {         console.log("screenheight less elementheight");                $('.hs-info p').css({             display: 'none'         }),         $('.hs-info .btn-slide').css({             padding: '10px 0px 0px 0px'         }),         $('.hs-sponsor').css({             display: 'none'         })     } else {         console.log("screenheight not less elementheight");                $('.hs-info .btn-slide').css({             padding: '0px'         }),         $('.hs-sponsor').css({             display: 'block'         }),         $(".hs-info p").css({             display: 'block'         })     } }  settocenterofparent( $('.hs-caption'), document.body, true, false); fullscreen(); scalar();  jquery(window).resize(function() {     scalar();     settocenterofparent( $('.hs-caption'), document.body, true, false);     fullscreen();          });  console.log("height:", elementheight); console.log("total height:", elementheight + heightoffset);  console.log("screenheight:", screenheight);  console.log("heightoffset:", heightoffset);  console.log("upcomingheader:", upcomingheader);      });

as target not clear, can small code editing make more easy read, , maybe little performance improvement.

jquery(document).ready(function($) {   // define share variables.   var element = $('.hs-caption');   var elementwidth, elementheight;   var screenwidth, screenheigth;   var upcomingheader = $('.fold-header').height() * 2.0;   var heightoffset;   var totalheight;   var height_ratio = 1.25;   var paddingelements = $('.hs-info .btn-slide');   var displayelements = $('.hs-info p, .hs-sponsor');   var resize_deley = 200;   var delayedhandler = null;    function onresize() {     updatesetting();     settocenterofparent(element, $(document.body), true, false);     fullscreen();     scalar();   };    function scalar() {     var innerheight = window.innerheight;     var totalelementheight = totalheight * height_ratio + upcomingheader;     var isscreensmaller = (innerheight < totalelementheight);     var padding = isscreensmaller ? '10px 0px 0px 0px' : '0px';     var display = isscreensmaller ? 'none' : 'block';     paddingelements.css('padding', padding);     displayelements.css('display', display);   }    function updatesetting(){     screenwidth = $(window).width();     screenwidth = $(window).height();     elementwidth = element.width();     elementheight = element.height();     heightoffset = (screenheight > 960) ? 220 : 200;     totalheight = elementheight + heightoffset;   }    function fullscreen() {     $('#hero').css({       width: screenwidth,       height: screenheigth     });   }    function settocenterofparent(element, parent, ignorewidth, ignoreheight) {     var parentwidth = parent.width();     var parentheight = parent.width();     if (!ignorewidth) {       element.css('left', parentwidth/2 - elementwidth/2);     }     if (!ignoreheight) {       element.css('top', heightoffset);     }   }    // init   onresize();    $(window).resize(function() {     // don't     if (delayedhandler !== null) {       cleartimeout(delayedhandler);     }     // delayed function executed, updates when user stop     // resizing fixed amount of time.     delayedhandler = settimeout(onresize, resize_deley);   });    console.log("height:", elementheight);   console.log("total height:", elementheight + heightoffset);   console.log("screenheight:", screenheight);   console.log("heightoffset:", heightoffset);   console.log("upcomingheader:", upcomingheader); });

the idea is:

  1. pull out of elements queried again , again, $('.hs-info .btn-slide') , $('.hs-info p, .hs-sponsor'), $('.hs-caption') seems used, pull out.
  2. do samething variables, here i'm not sure if use settocenterofparent other elements, i'll try input jquery wrapped element, can directly use jquery on them in function.
  3. elementwidth/elementheight here not clear whether it'll change or not, remain code not edited.
  4. add settimeout resize, jquery won't lots of computation during user resizing window, , 0.2 sec's delay should fast enough user won't feel delay(or can adjust resize_deley smaller number).
  5. unless you're using library conflict jquery, keep code style same preferable, change jquery(foo).bar $(foo).bar consistency.

i believe should can do, if there's no example jsfiddle, demonstrate code for.


Comments

Post a Comment

Popular posts from this blog

powershell Start-Process exit code -1073741502 when used with Credential from a windows service environment -

i'm running strange behavior powershell start-process call. here call: $process = start-process ` "c:\somepath\mybinary.exe" ` -passthru ` -credential $defaultcredential ` -wait ` -workingdirectory "c:\somepath" ` -loaduserprofile if ($process.exitcode -ne 0) { #do } this call return exit code - 1073741502 . after quick search, exit code seems related generic error when program not load required dll (aka. status_dll_init_failed ). when run without -credential $credential program runs correctly. in order isolate problem, manually launched some.exe in prompt target credential , runs smoothly. so problem seems come way start-process cmdlet launch process. i found potential solutions problem tried apply no luck : link , link . would have idea of what's going on here ? edit 1: run proc mon monitoring program activities when launched directly or via powershell script. problem seems occur when loading kernelbase
Read more

twig - Using Twigbridge in a Laravel 5.1 Package -

i'm trying create laravel 5.1 package uses twigbridge instead of .php views. can normal .php views display fine, when try make use of .twig templates i'm met error. possible use twigbridge templates when creating views laravel package or pretty stuck blade , php ? edit 1: loading twig template without extending works. it's when start using {% extends 'file' %} error comes out. i error error loading /virtual/laravel/packages/username/mypackage/src/views/sample.twig: template "templates.master" not defined () in "/virtual/laravel/packages/username/mypackage/src/views/sample.twig" @ line 1. my folders username |_ mypackage |_ src |_ controllers - samplecontroller.php |_ views |_ templates - master.twig - sample.twig twig template sample.twig {% extends 'templates.master' %} {% block content %} {{ parent()
Read more

c# - LINQ join Entities from HashSet's, Join vs Dictionary vs HashSet performance -

i have hashset's each stores t, have written test application compares different relation algorithms can think of, i'm not pleased results getting. does there exist more efficient ways of achieving object relations, once testing? using system; using system.collections.generic; using system.linq; using system.text; using system.threading.tasks; using system.diagnostics; namespace linqtests { class program { static void main(string[] args) { hashset<user> usertable = new hashset<user>(); hashset<userproperty> userpropertytable = new hashset<userproperty>(); #region lets create dummy data. console.writeline("please wait while creating dummy data, can take while..."); console.writeline(""); int rows = 1000000; for(int x = 0; x < rows; x++) { random rnd = new random(); // ad
Read more