Catching an Exception and rethrowing in C# - can it keep its type? -


we have business-critical bit of legacy code, , methods relatively large , code mess. without test framework , being critical our debugging abilities limited. logging messages not useful - "object not set instance of object"... somewhere in 500 lines of code call other methods. because method body 1 big try/catch specific exceptions being caught.

i want propose address better error logging want minimise impact on method. need carry on normal, because business critical. such, people scared touch need check understanding before put idea forward. say, cannot make change , test myself without writing test harness. don't have time due firefighting, , being last thing on friday.

i think way insert smaller try/catch blocks inside method body catch exceptions, log useful information, rethrow specific catch handlers below.

public int somefunc() {     try     {         // many lines of code          // want wrap call gives problems         try         {             brittlefunc(arg1, arg2, ..., arg15);         }         catch (exception e)         {             // log params repro in unit test , rethrow             log(args);             throw;         }          // many more lines of code      }     catch(customexception1 e)     {         //     }     // more...     catch(customexception9 e)     {         //     }     return someint; }

in inner try/catch write specific catch handlers match @ bottom, messy.

if catch customexception2 inside catch(exception e) , rethrow, end in catch(customexception2 e) ?

yes can that. inside first catch, exception treaded base exception when rethrow next catch catch it's real type.

when rethrow exception please use throw; not thrown ex; see here why


Comments

Post a Comment

Popular posts from this blog

powershell Start-Process exit code -1073741502 when used with Credential from a windows service environment -

i'm running strange behavior powershell start-process call. here call: $process = start-process ` "c:\somepath\mybinary.exe" ` -passthru ` -credential $defaultcredential ` -wait ` -workingdirectory "c:\somepath" ` -loaduserprofile if ($process.exitcode -ne 0) { #do } this call return exit code - 1073741502 . after quick search, exit code seems related generic error when program not load required dll (aka. status_dll_init_failed ). when run without -credential $credential program runs correctly. in order isolate problem, manually launched some.exe in prompt target credential , runs smoothly. so problem seems come way start-process cmdlet launch process. i found potential solutions problem tried apply no luck : link , link . would have idea of what's going on here ? edit 1: run proc mon monitoring program activities when launched directly or via powershell script. problem seems occur when loading kernelbase
Read more

twig - Using Twigbridge in a Laravel 5.1 Package -

i'm trying create laravel 5.1 package uses twigbridge instead of .php views. can normal .php views display fine, when try make use of .twig templates i'm met error. possible use twigbridge templates when creating views laravel package or pretty stuck blade , php ? edit 1: loading twig template without extending works. it's when start using {% extends 'file' %} error comes out. i error error loading /virtual/laravel/packages/username/mypackage/src/views/sample.twig: template "templates.master" not defined () in "/virtual/laravel/packages/username/mypackage/src/views/sample.twig" @ line 1. my folders username |_ mypackage |_ src |_ controllers - samplecontroller.php |_ views |_ templates - master.twig - sample.twig twig template sample.twig {% extends 'templates.master' %} {% block content %} {{ parent()
Read more

c# - LINQ join Entities from HashSet's, Join vs Dictionary vs HashSet performance -

i have hashset's each stores t, have written test application compares different relation algorithms can think of, i'm not pleased results getting. does there exist more efficient ways of achieving object relations, once testing? using system; using system.collections.generic; using system.linq; using system.text; using system.threading.tasks; using system.diagnostics; namespace linqtests { class program { static void main(string[] args) { hashset<user> usertable = new hashset<user>(); hashset<userproperty> userpropertytable = new hashset<userproperty>(); #region lets create dummy data. console.writeline("please wait while creating dummy data, can take while..."); console.writeline(""); int rows = 1000000; for(int x = 0; x < rows; x++) { random rnd = new random(); // ad
Read more