java - Checking doubles for equality and Sonar issues -


we checking quality of our code using sonar, , sonar found code compares float or double equality constant value this:

if (x == 0.0) { … }

the value variable compared (0.0) constant, , in case variable can equal value, value isn't computed set via constant. typically used check whether variable hasn't been set yet or still @ initialization state, e. g. -1.0 might used "not yet set" in cases value can positive.

so, since these values never computed set constants, sonar complaint not useful us. computed values (or fractured ones not precisely representable floats or doubles) complaint test equality makes sense.

the question have is: best practice change code sonar not complain anymore?

i see several options:

  1. extract "test-for-unset" special test function; reduce number of occurrences (to 1), not issue in general.
  2. mark code sonar ignore special decorator. avoid using such decorators.
  3. hide comparison behind sth (0.0 <= x && x <= 0.0) or !(x != 0.0) (which seems okay sonar).
  4. calling double.doubletorawlongbits() compare bits of values this: (double.doubletorawlongbits(x) != double.doubletorawlongbits(0.0)).
  5. other ideas?

none of these solutions , thought, maybe, there better 1 out there can't think of.

i go second option:

mark code sonar ignore special decorator.

don't slave static code analysis tools. they're not perfect, , there's nothing wrong telling them shut up. personal practice when using annotations @suppresslint include comment explaining why i'm using it.

that said, create constant code more self-explanatory:

private static final double uninitialized = 0.0; if (x == uninitialized) { … }

Comments

Post a Comment

Popular posts from this blog

powershell Start-Process exit code -1073741502 when used with Credential from a windows service environment -

i'm running strange behavior powershell start-process call. here call: $process = start-process ` "c:\somepath\mybinary.exe" ` -passthru ` -credential $defaultcredential ` -wait ` -workingdirectory "c:\somepath" ` -loaduserprofile if ($process.exitcode -ne 0) { #do } this call return exit code - 1073741502 . after quick search, exit code seems related generic error when program not load required dll (aka. status_dll_init_failed ). when run without -credential $credential program runs correctly. in order isolate problem, manually launched some.exe in prompt target credential , runs smoothly. so problem seems come way start-process cmdlet launch process. i found potential solutions problem tried apply no luck : link , link . would have idea of what's going on here ? edit 1: run proc mon monitoring program activities when launched directly or via powershell script. problem seems occur when loading kernelbase
Read more

twig - Using Twigbridge in a Laravel 5.1 Package -

i'm trying create laravel 5.1 package uses twigbridge instead of .php views. can normal .php views display fine, when try make use of .twig templates i'm met error. possible use twigbridge templates when creating views laravel package or pretty stuck blade , php ? edit 1: loading twig template without extending works. it's when start using {% extends 'file' %} error comes out. i error error loading /virtual/laravel/packages/username/mypackage/src/views/sample.twig: template "templates.master" not defined () in "/virtual/laravel/packages/username/mypackage/src/views/sample.twig" @ line 1. my folders username |_ mypackage |_ src |_ controllers - samplecontroller.php |_ views |_ templates - master.twig - sample.twig twig template sample.twig {% extends 'templates.master' %} {% block content %} {{ parent()
Read more

c# - LINQ join Entities from HashSet's, Join vs Dictionary vs HashSet performance -

i have hashset's each stores t, have written test application compares different relation algorithms can think of, i'm not pleased results getting. does there exist more efficient ways of achieving object relations, once testing? using system; using system.collections.generic; using system.linq; using system.text; using system.threading.tasks; using system.diagnostics; namespace linqtests { class program { static void main(string[] args) { hashset<user> usertable = new hashset<user>(); hashset<userproperty> userpropertytable = new hashset<userproperty>(); #region lets create dummy data. console.writeline("please wait while creating dummy data, can take while..."); console.writeline(""); int rows = 1000000; for(int x = 0; x < rows; x++) { random rnd = new random(); // ad
Read more